Closed
Conversation
Owner
|
This looks good but is there a substantial benefit over just using |
Contributor
Author
|
It just successfully get correct arguments for detecting Minecraft, while sysinfo in #15 get empty arguments before. I also did some experiments about notification with wmi instead of polling mentioned in #17, but it seems only increase the memory usage and may need more effort to optimize it. |
Contributor
Author
|
Tried to benchmark with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use WMI to list process, WMI seems available since XP
tested in win10, arguments are listed without admin rights
may further work on event watching with
__InstanceCreationEventand__InstanceDeletionEvent, but seems need big changes and don't bring much improvements